Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skins: Made titlebar reflect focus status when using classic skins in gtk mode #159

Closed
wants to merge 9 commits into from

Conversation

y0shir
Copy link

@y0shir y0shir commented Apr 11, 2024

This is a rework of merge request #158
This makes main, equalizer and playlist window all use focused versions of titlebars when focus in on either of them and unfocused when none of them have focus.

@y0shir y0shir changed the title Made titlebar reflect focus status when using classic skins in gtk mode skins: Made titlebar reflect focus status when using classic skins in gtk mode May 12, 2024
@y0shir
Copy link
Author

y0shir commented May 28, 2024

This is my first time contributing to open source project, so I am not sure if I didn't do something. Should have I updated copyright?

@radioactiveman
Copy link
Member

This is my first time contributing to open source project, so I am not sure if I didn't do something. Should have I updated copyright?

Sorry for the missing / late reply. My focus right now is to release Audacious 4.4 soon. And thanks for your contribution. 👍

What I noticed so far is:

  • Implement the feature like it was done for skins-qt (see my commit in Made titlebar reflect focus status #158). The setting Display active titlebar when any window is focused is for example missing here.
  • The code style is wrong in many aspects (tabs instead of spaces, placement of parentheses and curly brackets, ...). Please use the same style as in the existing code.

@jlindgren90
Copy link
Member

I implemented this a bit differently in 8c2e983, following the Qt version. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants